Fix some minor warnings in the matching package #4608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yycptt
approved these changes
Jul 12, 2023
service/matching/db.go
Outdated
| func (db *taskQueueDB) GetUserData( | ||
| ctx context.Context, | ||
| ) (*persistencespb.VersionedTaskQueueUserData, chan struct{}, error) { | ||
| func (db *taskQueueDB) GetUserData(context.Context) (*persistencespb.VersionedTaskQueueUserData, chan struct{}, error) { |
There was a problem hiding this comment.
nit: I thought the original version is better and makes the line shorter?
There was a problem hiding this comment.
Reverted except removing the param name
service/matching/task_reader.go
Outdated
Comment on lines
238
to
242
| type tasksBatch struct { | ||
| Tasks []*persistencespb.AllocatedTaskInfo | ||
| ReadLevel int64 | ||
| IsReadBatchDone bool | ||
| } |
There was a problem hiding this comment.
nit: getTasksBatchResponse maybe? read level and the done flag look like metadata to the returned batch of tasks.
do those fields have to be exported?
There was a problem hiding this comment.
Renamed and made them unexported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
I went through all the GoLand IDE inspection errors in the matching package, and I fixed the ones that seemed relevant. Most of them are little typos.
Why?
To clean things up a bit, make it easier to find actual errors from inspection, make sure these don't have to get included in other actual behavioral changes.
How did you test it?
I made sure not to include any behavioral changes, even small things like replacing
err ==witherrors.Is.Potential risks
Is hotfix candidate?