Add activity / workflow task version check #4580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yux0
approved these changes
Jul 7, 2023
yycptt
approved these changes
Jul 10, 2023
| runID string, | ||
| scheduledEventID int64, | ||
| activityId string, | ||
| activityType string, |
There was a problem hiding this comment.
why do we need activityType in the token? for metrics?
There was a problem hiding this comment.
yux0
reviewed
Jul 10, 2023
| "", | ||
| 1, | ||
| nil, | ||
| common.EmptyVersion, |
There was a problem hiding this comment.
any future plan to use a real version?
There was a problem hiding this comment.
no, the *ActivitybyID APIs are on the deprecation path, and the contract does not include clock or version
| (token.StartedEventId != common.EmptyEventID && token.StartedEventId != currentWorkflowTask.StartedEventID) { | ||
| (token.StartedEventId != common.EmptyEventID && token.StartedEventId != currentWorkflowTask.StartedEventID) || | ||
| currentWorkflowTask.Attempt != token.Attempt || | ||
| (token.Version != common.EmptyVersion && token.Version != currentWorkflowTask.Version) { |
There was a problem hiding this comment.
is it possible token.Version > currentWorkflowTask.Version? I am not sure if a workflow task retry would update ms wt version.
There was a problem hiding this comment.
token version comes from workflow task, so if workflow task is updated, then corresponding token version should be the newest value
yux0
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
Make activity / workflow task check more accurate
How did you test it?
Existing tests
Potential risks
N/A
Is hotfix candidate?
N/A