properly fix migration in mem ack aggregation #4571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxing1292
added a commit
that referenced
this pull request
Jul 5, 2023
…ased aggregation cannot be unified (#4571)
yux0
reviewed
Jul 7, 2023
Comment on lines
+400
to
+401
| remoteClusterInfo.AckedReplicationTaskIDs[remoteShardID] = ackTaskID | ||
| remoteClusterInfo.AckedReplicationTimestamps[remoteShardID] = ackTimestamp |
There was a problem hiding this comment.
One thing I am not following, why the acked task id can be used across different share ids?
There was a problem hiding this comment.
for polling mode:
targer cluster's 1 poller may poll & ack on behalf of >= 1 shards, here source cluster should update all relevant shard's ack task IDs
for streaming mode:
each target shard will has its own grpc stream & update ack using reader ID (cluster ID + shard ID)
yux0
approved these changes
Jul 7, 2023
|
Is it hotfix candidate or not? If not, remove 1.21.2 tag, if yes, please add it to description. |
wxing1292
added a commit
that referenced
this pull request
Jul 7, 2023
…ased aggregation cannot be unified (#4571)
this PR is, take a look at the github tag |
wxing1292
added a commit
that referenced
this pull request
Jul 13, 2023
…ased aggregation cannot be unified (#4571)
wxing1292
added a commit
that referenced
this pull request
Jul 14, 2023
* Fix migration in mem ack aggregation, since sender based / receiver based aggregation cannot be unified
dnr
pushed a commit
that referenced
this pull request
Jul 21, 2023
* Fix migration in mem ack aggregation, since sender based / receiver based aggregation cannot be unified
dnr
pushed a commit
that referenced
this pull request
Jul 21, 2023
* Fix migration in mem ack aggregation, since sender based / receiver based aggregation cannot be unified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
Correctly unify sender based & receiver based ack aggregation
How did you test it?
UT
Potential risks
N/A
Is hotfix candidate?
1.21.2