Allow context disable frontend redirection #4547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxing1292
requested review from
hehaifengcn,
meiliang86,
yux0,
feedmeapples and
yiminc
yux0
reviewed
Jun 27, 2023
| @@ -42,9 +44,13 @@ import ( | |||
| "go.temporal.io/server/common/rpc/interceptor" | |||
| ) | |||
|
|
|||
| var ( | |||
| const ( | |||
| dcRedirectionContextHeaderName = "xdc-redirection" | |||
There was a problem hiding this comment.
nit: Define this in common/headers.go
There was a problem hiding this comment.
this header will only be used by the redirection interceptor (not a common header)
do you still prefer to move this header definition to common/headers.go?
There was a problem hiding this comment.
ok. I was thinking define all headers in one place. I am fine with either way.
yux0
approved these changes
Jun 27, 2023
feedmeapples
approved these changes
Jul 5, 2023
wxing1292
added a commit
that referenced
this pull request
Jul 13, 2023
* Add RPC header xdc-redirection, allowing disable DC redirection, default to redirect
wxing1292
added a commit
that referenced
this pull request
Jul 14, 2023
* Add RPC header xdc-redirection, allowing disable DC redirection, default to redirect
dnr
pushed a commit
that referenced
this pull request
Jul 21, 2023
* Add RPC header xdc-redirection, allowing disable DC redirection, default to redirect
dnr
pushed a commit
that referenced
this pull request
Jul 21, 2023
* Add RPC header xdc-redirection, allowing disable DC redirection, default to redirect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
xdc-redirection, allowing disable DC redirection, default to redirectWhy?
Useful if caller does not want to be redirected
How did you test it?
UT
Potential risks
N/A
Is hotfix candidate?
N/A