Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent scavenger from removing build ids that were recently default for a set #4527

Merged

Conversation

bergundy
Copy link
Member

Part 3 of the last minute refactoring of versioning data timestamps (see #4524 and #4526).

With this change, the scavenger uses the build id became_default_timestamp to determine whether it should be considered for removal.

From the documentation in code:

// If a build id was still default recently, there may be:
// 1. workers with that identifier processing tasks
// 2. workflows with that identifier that have yet to be indexed in visibility
// The scavenger should allow enough time to pass before cleaning these build ids.

Note that this is stacked on top of #4526 and only the last commit should be reviewed.

@bergundy bergundy requested a review from a team as a code owner June 22, 2023 00:31
@bergundy bergundy force-pushed the buildid-scavenger-removal-min-duration branch from 914109e to 5627a5d Compare June 22, 2023 01:00
@bergundy bergundy enabled auto-merge (squash) June 22, 2023 01:01
@bergundy bergundy merged commit 8699916 into temporalio:master Jun 22, 2023
@bergundy bergundy deleted the buildid-scavenger-removal-min-duration branch June 22, 2023 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants