Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More functional tests for worker versioning #4446

Merged
merged 7 commits into from
Jun 8, 2023
Merged

More functional tests for worker versioning #4446

merged 7 commits into from
Jun 8, 2023

Conversation

dnr
Copy link
Member

@dnr dnr commented Jun 6, 2023

What changed?

Add more tests and followups from #4375:

  • Rename isVersioned to managesSpecificVersionSet
  • Test wtih UseBuildIDForVersioning: false
  • Test dispatch with activities that fail or timeout (to test retry)
  • Test activity with compatible version
  • Test child workflow with compatible version
  • Test query dispatch

Why?
More tests

How did you test it?
More tests

Potential risks

Is hotfix candidate?

@dnr dnr requested a review from bergundy June 6, 2023 19:19
@dnr dnr requested a review from a team as a code owner June 6, 2023 19:19
@dnr dnr merged commit e5d58dc into temporalio:master Jun 8, 2023
@dnr dnr deleted the ver21 branch June 8, 2023 15:18
mindaugasrukas pushed a commit that referenced this pull request Jun 8, 2023
@dnr @mindaugasrukas
More functional tests for worker versioning (#4446)
f19e1ee
@norberthu norberthu mentioned this pull request Jun 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bergundy bergundy bergundy approved these changes

Assignees
No one assigned
Labels
release/1.21.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dnr @bergundy