Comments and event attributes in expected history in tests #4426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexshtin
force-pushed
the
feature/comments-history
branch
from
555a81f to
00db241
Compare
mmcshane
suggested changes
Jun 1, 2023
There was a problem hiding this comment.
Not sure why we'd parse but then keep in string form? If we're going to do this sort of work, let's parse into a structured form so that it can be manipulated and more meaningfully diff'd. You can do a Good Enough parser in one ugly line or three reasonable lines. https://go.dev/play/p/obvWCfx_sBJ
alexshtin
force-pushed
the
feature/comments-history
branch
from
b3360ef to
6e518a2
Compare
alexshtin
changed the title
alexshtin
force-pushed
the
feature/comments-history
branch
from
b73fc88 to
569a721
Compare
mmcshane
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Add ability to add comments and event attributes one wants to assert to expected history in functional tests.
Why?
To improve tests maintainability and increase coverage. I am going to add more comments and attributes to other histories later.
How did you test it?
Modified one test.
Potential risks
No risks.
Is hotfix candidate?
No.