Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make server fx init more extendable #4419

Merged
merged 1 commit into from
May 31, 2023
Merged

Make server fx init more extendable #4419

merged 1 commit into from
May 31, 2023

Conversation

dnr
Copy link
Member

@dnr dnr commented May 31, 2023

What changed?
Make NewServerFx more easily usable by alternate initialization code

Why?
Make it easier to embed server as a library

How did you test it?
Manual tests

Potential risks

Is hotfix candidate?

@dnr dnr requested a review from a team as a code owner May 31, 2023 01:07
mindaugasrukas
mindaugasrukas approved these changes May 31, 2023
View reviewed changes
Copy link
Contributor

@mindaugasrukas mindaugasrukas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future, we might consider using fx.Replace.

@dnr dnr merged commit 2a4aec0 into temporalio:master May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mindaugasrukas mindaugasrukas mindaugasrukas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dnr @mindaugasrukas