Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow workflow to complete if there are updates in the registry #4412

Merged

Conversation

alexshtin
Copy link
Member

@alexshtin alexshtin commented May 26, 2023

What changed?
Allow workflow to complete if there are updates in the registry.

Why?
If updates are keep coming but workflow reached to the completion (especially trying to do ContinueAsNew) it is better to allow workflow to complete.

How did you test it?
Added new functional tests.

Potential risks
No risks.

Is hotfix candidate?
No.

@alexshtin alexshtin requested a review from a team as a code owner May 26, 2023 19:38
@alexshtin alexshtin merged commit 81eaa77 into temporalio:master May 26, 2023
@alexshtin alexshtin deleted the feature/cancel-update-on-wf-complete-1 branch May 26, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants