Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve task latency calculation and retry behavior #4408

Merged
merged 2 commits into from
May 30, 2023
Merged

Improve task latency calculation and retry behavior #4408

merged 2 commits into from
May 30, 2023

Conversation

yycptt
Copy link
Member

@yycptt yycptt commented May 26, 2023 •
edited
Loading

What changed?

  • Do not retry task while holding the goroutine. <- the original intention, but currently retry policy with max attempts = 1 will retry once, so in total 2 attemtps.
  • Re-purpose task_latency metric, to be in memory no-user latency. to prevent noisy alerts.

Why?

How did you test it?

Potential risks

Is hotfix candidate?

@yycptt yycptt requested a review from yiminc May 26, 2023 09:11
@yycptt yycptt marked this pull request as ready for review May 26, 2023 22:45
@yycptt yycptt requested a review from a team as a code owner May 26, 2023 22:45
yiminc
yiminc approved these changes May 26, 2023
View reviewed changes
@yycptt yycptt force-pushed the task-retry-and-latency branch from 5e85450 to 6b6a999 Compare May 30, 2023 19:04
@yycptt yycptt merged commit 8aab8ab into temporalio:master May 30, 2023
@yycptt yycptt deleted the task-retry-and-latency branch May 30, 2023 22:36
@yycptt yycptt mentioned this pull request Jun 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yiminc yiminc yiminc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yycptt @yiminc