Address comments from #4346 review #4405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnr
approved these changes
May 26, 2023
| err error | ||
| lock sync.Mutex | ||
| matchingClient matchingservice.MatchingServiceClient | ||
| futures map[string]future.Future[*matchingservice.GetWorkerBuildIdCompatibilityResponse] |
| @@ -53,3 +57,20 @@ func VersionStampToBuildIdSearchAttribute(stamp *commonpb.WorkerVersionStamp) st | |||
| } | |||
| return UnversionedBuildIdSearchAttribute(stamp.BuildId) | |||
| } | |||
|
|
|||
| func FindBuildId(versionSets []*taskqueuepb.CompatibleVersionSet, buildId string) (setIndex, indexInSet int) { | |||
There was a problem hiding this comment.
ok, I'll move them into a versioning package
bergundy
changed the title
bergundy
force-pushed
the
address-davids-comments
branch
from
a2d884e to
d844235
Compare
bergundy
force-pushed
the
address-davids-comments
branch
from
d844235 to
f9ece1e
Compare
dnr
pushed a commit
that referenced
this pull request
May 26, 2023
dnr
pushed a commit
that referenced
this pull request
May 26, 2023
dnr
pushed a commit
that referenced
this pull request
May 26, 2023
dnr
pushed a commit
that referenced
this pull request
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.