Do not let API call timeout if workflow can't be locked #4341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samanbarghi
force-pushed
the
feature/no-API-call-timeout-if-workflow-cannot-be-locked
branch
from
cd4ec81 to
9b1fe80
Compare
samanbarghi
force-pushed
the
feature/no-API-call-timeout-if-workflow-cannot-be-locked
branch
from
9b1fe80 to
bc850c3
Compare
yycptt
reviewed
May 18, 2023
yycptt
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Returning an error prior to workflow timeout when tryting to lock the
workflow, and if it takes too long.
Why?
API can timeout trying lock the workflow when the system is busy and triggers
many alerts. We are returning an error other than context deadline exceeded.
How did you test it?
Potential risks
Is hotfix candidate?