Prevent workflow close when updates are undelivered #4313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelSnowden
approved these changes
May 11, 2023
added 2 commits
May 11, 2023 15:19
Prevent a workflow from closing if there are workflow updates that have been admitted into the registry but which have not yet been seen by the workflow execution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Prevent a workflow from closing if there are workflow updates that have been admitted into the registry but which have not yet been seen by the workflow execution. Previous behavior was to prevent workflow close for any incomplete updates.
Why?
Consensus that this is the desired behavior. If a workflow execution has seen the update, it has also had the opportunity to prevent itself from completing. If the workflow has not taken action to prevent completion when it had the chance then the server should assume that was intentional.
How did you test it?
Unit and functional tests changed to expect new behavior
Potential risks
low
Is hotfix candidate?
no