Async Updates and the Poll API #4309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmcshane
commented
May 10, 2023
mmcshane
changed the title
MichaelSnowden
suggested changes
May 11, 2023
MichaelSnowden
approved these changes
May 11, 2023
added 6 commits
May 11, 2023 14:38
Look up the referenced update and wait on its outcome.
Can't control when WaitOutcome is called and it may reasonably be called at a point in time when the workflow context lock is not held so rather than loading the outcome lazily, do it when the Update object is first loaded.
alexshtin
reviewed
May 12, 2023
| ) (*historyservice.PollWorkflowExecutionUpdateResponse, error) { | ||
| updateRef := req.GetRequest().GetUpdateRef() | ||
| wfexec := updateRef.GetWorkflowExecution() | ||
| upd, ok, err := func() (*update.Update, bool, error) { |
There was a problem hiding this comment.
Correct, for defer.
| @@ -39,9 +37,6 @@ import ( | |||
| const libraryName = "go.temporal.io/service/history/workflow/update" | |||
|
|
|||
| type ( | |||
| // lazyOutcome adapts a func to the future.Future[*updatepb.Outcome] interface | |||
There was a problem hiding this comment.
We'll think of another use for it. Let lazyOutcome live on in your heart.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Enable async updates and implement the PollWorkflowExecutionUpdate API
Why?
Features are dope
How did you test it?
New unit tests here, async update feature test in the features repo (not in main yet - waiting for this PR to land)
Potential risks
low but I will add a feature flag around async update requests in a subsequent PR
Is hotfix candidate?
No