Use search attribute type map in visibility archival #4304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelSnowden
commented
May 9, 2023
|
|
||
| ExpectArchiveHistory bool | ||
| ExpectArchiveVisibility bool | ||
| ExpectedMetrics []expectedMetric |
There was a problem hiding this comment.
I removed these and the log recorder messages because they're too much of a pain to maintain
dnr
reviewed
May 9, 2023
service/history/archival/archiver.go
Outdated
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| // It is safe to pass nil to typeMap here because search attributes type must be embedded by caller. |
There was a problem hiding this comment.
comment should change since we're not passing nil anymore
Comment on lines
47
to
48
| "go.uber.org/fx" | ||
| "go.uber.org/multierr" |
There was a problem hiding this comment.
put these imports up higher in the third party section
| @@ -212,8 +219,13 @@ func (a *archiver) archiveVisibility(ctx context.Context, request *Request, logg | |||
| return err | |||
| } | |||
|
|
|||
| saTypeMap, err := a.searchAttributeProvider.GetSearchAttributes(a.visibilityManager.GetIndexName(), false) | |||
There was a problem hiding this comment.
maybe: comment about why we're calling this here? not sure if it's necessary
rodrigozhou
approved these changes
May 9, 2023
MichaelSnowden
force-pushed
the
snowden/archival-fix
branch
from
07bc8b2 to
153d613
Compare
rodrigozhou
pushed a commit
that referenced
this pull request
May 13, 2023
* Use search attribute type map in visibility archival * pr comments
rodrigozhou
pushed a commit
that referenced
this pull request
May 16, 2023
* Use search attribute type map in visibility archival * pr comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
We now populate search attributes with type information before archiving them.
Why?
This information is not always embedded in the fields themselves, e.g., for schedules. This fixes #4270 .
How did you test it?
I reproduced the linked issue without this change, and then verified that it worked after this change. I repro'd by doing this:
invalid search attribute type: Unspecifiederror is thrown before this change.Potential risks
Unclear.
Is hotfix candidate?
The community should be notified that this bug existed, and that they should upgrade to fix it.