Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix task attempt reset #4276

Merged
merged 4 commits into from
May 3, 2023
Merged

Conversation

yycptt
Copy link
Member

@yycptt yycptt commented May 3, 2023

What changed?

  • Reset task attempt to 1 instead of 0

Why?

  • Attempt count should always start from 1, which is more natural.

How did you test it?

  • added new unit test

Potential risks

Is hotfix candidate?
yes

@yycptt yycptt requested a review from a team as a code owner May 3, 2023 19:52
@yycptt yycptt enabled auto-merge (squash) May 3, 2023 19:56
@yycptt yycptt merged commit 6e43d54 into temporalio:master May 3, 2023
@yycptt yycptt deleted the fix-task-attempt-reset branch May 3, 2023 21:18
yycptt added a commit that referenced this pull request May 3, 2023
samanbarghi pushed a commit to samanbarghi/temporal that referenced this pull request May 5, 2023
rodrigozhou pushed a commit that referenced this pull request May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants