[WIP] Fix error return bug and some minor code style #4234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yycptt
approved these changes
Apr 26, 2023
mindaugasrukas
changed the title
|
Working on adding tests.. |
yycptt
approved these changes
Apr 26, 2023
samanbarghi
pushed a commit
to samanbarghi/temporal
that referenced
this pull request
May 2, 2023
* Fix error return bug and some minor code style * Add unit tests * Update error formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Fixed some checks to return an error instead of always returning a
nil.Why?
Bigfix
How did you test it?
Unittest
Potential risks
That was made intentionally.
Is hotfix candidate?
Revert