Versioning data merge algo and hybrid logical clock utils #4205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergundy
force-pushed
the
versioning-data-merge
branch
from
105151e to
b565b4a
Compare
Sushisource
reviewed
Apr 24, 2023
| commonclock "go.temporal.io/server/common/clock" | ||
| ) | ||
|
|
||
| var ErrClocksEqual = errors.New("HybridLogicalClocks are equal") |
Sushisource
reviewed
Apr 24, 2023
Comment on lines
51
to
52
| // Merge and sort two sets of set IDs | ||
| func setContainsSetIDs(set *persistencepb.CompatibleVersionSet, ids []string) bool { |
Sushisource
approved these changes
Apr 24, 2023
dnr
reviewed
Apr 25, 2023
| // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | ||
| // THE SOFTWARE. | ||
|
|
||
| package hybrid_logical_clock |
There was a problem hiding this comment.
does this really deserve a new package? just put it in common/clock.. they're used together anyway so anyone importing this needs to import that too
| @@ -150,6 +153,7 @@ func NewEngine( | |||
| namespaceRegistry: namespaceRegistry, | |||
| keyResolver: resolver, | |||
| clusterMeta: clusterMeta, | |||
| timeSource: clock.NewRealTimeSource(), // No need to mock this at the moment | |||
There was a problem hiding this comment.
can we get this from fx instead? just for consistency. I can do it in another PR if you don't want to touch the fx stuff
bergundy
added a commit
that referenced
this pull request
May 3, 2023
dnr
pushed a commit
that referenced
this pull request
May 11, 2023
dnr
pushed a commit
that referenced
this pull request
May 26, 2023
Note: This commit came from a feature branch and is not expected to build.
dnr
pushed a commit
to dnr/temporal
that referenced
this pull request
May 26, 2023
…#4205) Note: This commit came from a feature branch and is not expected to build.
dnr
pushed a commit
that referenced
this pull request
May 26, 2023
Note: This commit came from a feature branch and is not expected to build.
dnr
pushed a commit
that referenced
this pull request
May 26, 2023
Note: This commit came from a feature branch and is not expected to build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another PR for version set / user data replication.