Wire replication stream caller side #4178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hehaifengcn
reviewed
Apr 18, 2023
| for _, targetCluster := range namespaceEntry.ClusterNames() { | ||
| if f.SourceClusterShardID.ClusterName == targetCluster { | ||
| shouldProcessTask = true | ||
| break FilterLoop |
There was a problem hiding this comment.
why break with label? and can you add some comments on why the task should be processed?
There was a problem hiding this comment.
to me break with label will make the logic easier to read
yux0
approved these changes
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
Support replication stream between diff shard count
How did you test it?
Existing tests
Potential risks
N/A
Is hotfix candidate?
N/A