Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused exporter from openTelemetryProviderImpl #4169

Merged
merged 1 commit into from
Apr 17, 2023

Conversation

k24dizzle
Copy link
Contributor

@k24dizzle k24dizzle commented Apr 14, 2023

Doesn't seem like this field is actually used while meter, config, and server are:

func (r *openTelemetryProviderImpl) GetMeter() metric.Meter {
return r.meter
}
func (r *openTelemetryProviderImpl) Stop(logger log.Logger) {
ctx, closeCtx := context.WithTimeout(context.Background(), time.Second)
defer closeCtx()
if err := r.server.Shutdown(ctx); !(err == nil || err == http.ErrServerClosed) {
logger.Error("Prometheus metrics server shutdown failure.", tag.Address(r.config.ListenAddress), tag.Error(err))
}
}

@k24dizzle k24dizzle requested a review from a team as a code owner April 14, 2023 06:04
@CLAassistant
Copy link

CLAassistant commented Apr 14, 2023

CLA assistant check
All committers have signed the CLA.

@k24dizzle k24dizzle merged commit 2d0272c into master Apr 17, 2023
@k24dizzle k24dizzle deleted the kevin/exporter branch April 17, 2023 16:25
samanbarghi pushed a commit to samanbarghi/temporal that referenced this pull request Apr 17, 2023
samanbarghi pushed a commit to samanbarghi/temporal that referenced this pull request May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants