Validation API should use low priority lock #4140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxing1292
changed the title
yux0
approved these changes
Apr 5, 2023
yycptt
approved these changes
Apr 6, 2023
| @@ -51,6 +51,7 @@ func Invoke( | |||
| nil, | |||
| api.BypassMutableStateConsistencyPredicate, | |||
| workflowKey, | |||
| workflow.CallerTypeAPI, | |||
wxing1292
added a commit
that referenced
this pull request
Apr 13, 2023
* Use low priority lock for VerifyFirstWorkflowTaskScheduled API * Use low priority lock for VerifyChildExecutionCompletionRecorded API * Rename caller type to lock priority since some internal API use "low priority lock"
wxing1292
added a commit
that referenced
this pull request
Apr 13, 2023
* Use low priority lock for VerifyFirstWorkflowTaskScheduled API * Use low priority lock for VerifyChildExecutionCompletionRecorded API * Rename caller type to lock priority since some internal API use "low priority lock"
wxing1292
added a commit
that referenced
this pull request
Apr 13, 2023
* Use low priority lock for VerifyFirstWorkflowTaskScheduled API * Use low priority lock for VerifyChildExecutionCompletionRecorded API * Rename caller type to lock priority since some internal API use "low priority lock"
yycptt
pushed a commit
that referenced
this pull request
Apr 17, 2023
* Use low priority lock for VerifyFirstWorkflowTaskScheduled API * Use low priority lock for VerifyChildExecutionCompletionRecorded API * Rename caller type to lock priority since some internal API use "low priority lock"
samanbarghi
pushed a commit
to samanbarghi/temporal
that referenced
this pull request
May 2, 2023
* Use low priority lock for VerifyFirstWorkflowTaskScheduled API * Use low priority lock for VerifyChildExecutionCompletionRecorded API * Rename caller type to lock priority since some internal API use "low priority lock"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
too many concurrent child workflow start / completion verification call can cause replication starvation of parent workflow
How did you test it?
N/A
Potential risks
N/A
Is hotfix candidate?
N/A