Change Scan API to have no Order(ES) #4134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigozhou
reviewed
Mar 31, 2023
There was a problem hiding this comment.
You should add some validation in the Scan aPI to return an error if the query has an custom ORDER BY.
cc: @yiminc
common/persistence/visibility/store/elasticsearch/visibility_store.go
Outdated
Show resolved
Hide resolved
common/persistence/visibility/store/elasticsearch/visibility_store.go
Outdated
Show resolved
Hide resolved
common/persistence/visibility/store/elasticsearch/visibility_store_read_test.go
Outdated
Show resolved
Hide resolved
In that case, it might be better to refactor these functions a bit and also get rid of the control flag. |
yiminc
reviewed
Apr 1, 2023
common/persistence/visibility/store/elasticsearch/visibility_store.go
Outdated
Show resolved
Hide resolved
common/persistence/visibility/store/elasticsearch/visibility_store.go
Outdated
Show resolved
Hide resolved
Not yet, I will add that in a separate PR |
yiminc
approved these changes
Apr 1, 2023
rodrigozhou
reviewed
Apr 5, 2023
|
|
||
| func (s *visibilityStore) getFieldSorter(fieldSorts []*elastic.FieldSort) []elastic.Sorter { |
There was a problem hiding this comment.
This is only used by getListFieldSorter, no need to be a separate function.
Comment on lines
+94
to
+97
|
|
||
| searchParameterBuilder struct { | ||
| store *visibilityStore | ||
| } |
There was a problem hiding this comment.
This is not used anywhere. Remove it.
samanbarghi
added a commit
to samanbarghi/temporal
that referenced
this pull request
May 2, 2023
* Change Scan API to have no Order(ES) * Refactoring based on PR comments * PR comments * Fix return order
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Changed ElasticSearch Scan API to have no order (use "_doc").
Why?
Using sort order "_doc" when using Scan API has some optimizations in ES that
makes it faster to iterate over all workflows.
How did you test it?
Added unit tests
Potential risks
N/A
Is hotfix candidate?
No