Reconnect on a few more gocql errors #4132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mastermanu
approved these changes
Mar 31, 2023
alexshtin
approved these changes
Mar 31, 2023
yycptt
pushed a commit
that referenced
this pull request
Apr 17, 2023
BenEddy
added a commit
that referenced
this pull request
Jul 1, 2024
## What changed? Modifies gocql error handling introduced in #4132 to avoid recreating the gocql session on transient connection errors. ## Why? Recreating the session adds latency and isn't necessary when connections are closed or reset. ## How did you test it? Ran a prod-like workload and periodically restarted cassandra nodes. With the patch applied, we observed a reduction in p50 and p99 latency across persistence operations. ## Potential risks No ## Is hotfix candidate? No
BenEddy
added a commit
that referenced
this pull request
Jul 1, 2024
## What changed? Modifies gocql error handling introduced in #4132 to avoid recreating the gocql session on transient connection errors. ## Why? Recreating the session adds latency and isn't necessary when connections are closed or reset. ## How did you test it? Ran a prod-like workload and periodically restarted cassandra nodes. With the patch applied, we observed a reduction in p50 and p99 latency across persistence operations. ## Potential risks No ## Is hotfix candidate? No
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Add a few more errors to gocql session refresh logic
Why?
There are more than one error for Cassandra connection issue.
How did you test it?
eye_balls
Potential risks
No
Is hotfix candidate?
No