Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lock current execution on start workflow #4066

Merged
merged 1 commit into from
Mar 22, 2023
Merged

Lock current execution on start workflow #4066

merged 1 commit into from
Mar 22, 2023

Conversation

yycptt
Copy link
Member

@yycptt yycptt commented Mar 20, 2023

What changed?

Why?

  • Block on workflow lock instead of shard lock -> prevent noisy neighbor issue
  • Workflow lock latency will be subtracted when calculating service no-user latency -> reduce noisy alerts.

How did you test it?

  • Add unit test
  • Will try locally to see the metrics

Potential risks

Is hotfix candidate?

  • Yes.

@yycptt yycptt requested review from wxing1292 and yiminc March 20, 2023 23:54
@yycptt yycptt requested a review from a team as a code owner March 20, 2023 23:54
@yycptt yycptt merged commit e8be006 into temporalio:master Mar 22, 2023
@yycptt yycptt deleted the start-wf-lock-current branch March 22, 2023 03:25
yycptt added a commit that referenced this pull request Mar 24, 2023
@yycptt
Lock current execution on start workflow (#4066)
633a056
wxing1292 pushed a commit that referenced this pull request Apr 14, 2023
@yycptt @wxing1292
Lock current execution on start workflow (#4066)
669e488
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yiminc yiminc yiminc approved these changes

@wxing1292 wxing1292 Awaiting requested review from wxing1292

Assignees
No one assigned
Labels
release/1.20.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yycptt @yiminc