Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track and emit metrics for entities in a single workflow #4065

Merged
merged 3 commits into from
Mar 22, 2023
Merged

Track and emit metrics for entities in a single workflow #4065

merged 3 commits into from
Mar 22, 2023

Conversation

yycptt
Copy link
Member

@yycptt yycptt commented Mar 20, 2023

What changed?

  • Track and emit metrics for entities in a single workflow: activities, child workflows, user timers, cancel external, signal external and signal received.

Why?

  • Get observability into single workflow limitations

How did you test it?

  • Added one unit test & existing tests

Potential risks

  • Extra metrics

Is hotfix candidate?

  • Yes.

@yycptt yycptt requested a review from a team as a code owner March 20, 2023 22:34
@yycptt yycptt merged commit 66352ed into temporalio:master Mar 22, 2023
@yycptt yycptt deleted the single-workflow-entities-count branch March 22, 2023 18:45
@yycptt yycptt mentioned this pull request Mar 22, 2023
Merged
yycptt added a commit that referenced this pull request Mar 24, 2023
@yycptt
Track and emit metrics for entities in a single workflow (#4065)
a8b591d
wxing1292 pushed a commit that referenced this pull request Apr 14, 2023
@yycptt @wxing1292
Track and emit metrics for entities in a single workflow (#4065)
6069a75
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yiminc yiminc yiminc approved these changes

Assignees
No one assigned
Labels
release/1.20.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yycptt @yiminc