Handle errors when registering new queue readers #4055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiminc
approved these changes
Apr 7, 2023
| if !ok { | ||
| // this should never happen, we already ensured all readers are created. | ||
| // we have no choice but to put those slices back | ||
| reader.MergeSlices(splitSlices...) |
There was a problem hiding this comment.
write some noticeable logs, or even emit metric here?
| @@ -39,12 +39,13 @@ const ( | |||
| clearSliceThrottleDuration = 10 * time.Second | |||
| ) | |||
|
|
|||
| var _ Action = (*actionQueuePendingTask)(nil) | |||
There was a problem hiding this comment.
please add comment to explain what this action is about, what alert is it react to, and how does it mitigate the alert.
There was a problem hiding this comment.
yeah I will send follow up PRs to comment and add tests for those actions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
How did you test it?
Potential risks
Is hotfix candidate?