Move update registry from mutable state to workflow context #4032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexshtin
commented
Mar 9, 2023
| @@ -144,6 +145,8 @@ type ( | |||
| ctx context.Context, | |||
| now time.Time, | |||
| ) error | |||
| // TODO (alex-update): move this from workflow context. | |||
There was a problem hiding this comment.
This is because long term goal is to to store registry out of workflow cache.
| @@ -193,17 +181,6 @@ func (r *RegistryImpl) getAcceptedUpdateNoLock(protocolInstanceID string) *Updat | |||
| return nil | |||
| } | |||
|
|
|||
| func (r *RegistryImpl) clearFailure() *failurepb.Failure { | |||
There was a problem hiding this comment.
This is not needed anymore.
mmcshane
approved these changes
Mar 9, 2023
| @@ -754,6 +755,7 @@ func (handler *workflowTaskHandlerCallbacksImpl) verifyFirstWorkflowTaskSchedule | |||
|
|
|||
| func (handler *workflowTaskHandlerCallbacksImpl) createRecordWorkflowTaskStartedResponse( | |||
| ms workflow.MutableState, | |||
| updateRegistry update.Registry, | |||
There was a problem hiding this comment.
Minor and not blocking - this seems out of place here. Maybe better to pass the full workflow context and then extract the MS and registry within the function body?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Move update registry from mutable state to workflow context.
Why?
When workflow task is failed, mutable state is cleared and refreshed. This also clears update registry which might have updates not related to failed workflow task.
This PR moves updated registry one level above -- to workflow context. This allows mutable state to be cleared w/o clearing update registry.
How did you test it?
Modified integration test.
Potential risks
No risks.
Is hotfix candidate?
No.