Extract interface from membership.HostInfo #3996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelSnowden
force-pushed
the
snowden/hostinfo
branch
from
dbe69b8 to
805c239
Compare
yux0
reviewed
Mar 3, 2023
|
|
||
| package membership | ||
|
|
||
| type ringpopHostInfo struct { |
There was a problem hiding this comment.
I remember you move the file to a subfolder ringpop?
There was a problem hiding this comment.
Yes, that's in a later PR that depends on this change: #3999
yiminc
approved these changes
Mar 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
I renamed the HostInfo struct to the unexported
ringpopHostInfoand extracted an interface from it called HostInfo.Why?
To separate the membership interfaces from the ring pop implementation.
How did you test it?
No new executable statements.
Potential risks
It's a breaking change for anyone that depended on the HostInfo struct.
Is hotfix candidate?
No.