Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ExecutionTime rounding when using PostgreSQL #3952

Merged
merged 1 commit into from
Feb 14, 2023
Merged

Fix ExecutionTime rounding when using PostgreSQL #3952

merged 1 commit into from
Feb 14, 2023

Conversation

alexshtin
Copy link
Member

What changed?
Fix ExecutionTime rounding when using PostgreSQL.

Why?
ExecutionTime need to be properly converted to PostgreSQL datetime format using existing ToPostgreSQLDateTime function.

How did you test it?
Existing cron functional test should stop failing.

Potential risks
No risks.

Is hotfix candidate?
No.

@alexshtin alexshtin requested a review from a team as a code owner February 14, 2023 02:16
yycptt
yycptt approved these changes Feb 14, 2023
View reviewed changes
Copy link
Member

@yycptt yycptt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍 👍

@alexshtin alexshtin enabled auto-merge (squash) February 14, 2023 02:38
@alexshtin alexshtin merged commit 4b78d28 into temporalio:master Feb 14, 2023
@alexshtin alexshtin deleted the fix/postgres-time-rounding branch February 14, 2023 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yycptt yycptt yycptt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexshtin @yycptt