Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor history branch manipulation logic into its own utility #3946

Merged
merged 4 commits into from
Feb 28, 2023
Merged

Refactor history branch manipulation logic into its own utility #3946

merged 4 commits into from
Feb 28, 2023

Conversation

norberthu
Copy link
Contributor

What changed?

Why?

How did you test it?

Potential risks

Is hotfix candidate?

@norberthu norberthu requested a review from a team as a code owner February 13, 2023 20:11
@norberthu norberthu requested review from yycptt and yiminc February 13, 2023 21:15
@norberthu norberthu force-pushed the norbert/refactor-history-branch-util branch 3 times, most recently from 5666854 to ddbde70 Compare February 23, 2023 00:14
MichaelSnowden
MichaelSnowden approved these changes Feb 23, 2023
View reviewed changes
Copy link
Contributor

@MichaelSnowden MichaelSnowden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good, but it would be simpler if these were functions instead of object methods.

yycptt
yycptt reviewed Feb 23, 2023
View reviewed changes
@norberthu norberthu force-pushed the norbert/refactor-history-branch-util branch from ddbde70 to 766255a Compare February 24, 2023 00:08
@norberthu norberthu force-pushed the norbert/refactor-history-branch-util branch from 766255a to 47ef3b5 Compare February 24, 2023 00:18
@norberthu norberthu requested a review from yycptt February 24, 2023 02:02
yycptt
yycptt reviewed Feb 27, 2023
View reviewed changes
@norberthu
Copy link
Contributor Author

@yycptt I ended up moving NewHistoryBranch() out of the interface. See updated PR

@norberthu norberthu requested a review from yycptt February 28, 2023 06:48
@norberthu norberthu merged commit eea242d into master Feb 28, 2023
@norberthu norberthu deleted the norbert/refactor-history-branch-util branch February 28, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelSnowden MichaelSnowden MichaelSnowden approved these changes

@yycptt yycptt yycptt approved these changes

@yiminc yiminc Awaiting requested review from yiminc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@norberthu @MichaelSnowden @yycptt