Fix MySQL visibility indexes with close_time column #3927
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Cast max datetime string to datetime type in MySQL COALESCE calls.
Refactor
getCoalesceCloseTimeExpr
to be part ofpluginConverter
interface.Why?
MySQL coalesce with datetime and string results in a string, which can cause incorrect comparisons with datetime (eg: times
12:12:12
is different than12:12:12.000
).So, adding a
CAST
to max datetime so it's handled correctly as datetime type column.This also fixes flaky tests in
TestMySQL8VisibilityPersistenceSuite
How did you test it?
Hard coded a time with leading zeros, and tests are now passing.
Potential risks
No risks.
Is hotfix candidate?
No.