Keep queue factory group tag #3880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yycptt
approved these changes
Feb 1, 2023
MichaelSnowden
changed the title
MichaelSnowden
force-pushed
the
snowden/qs-revert
branch
from
9463fda to
4eeceb4
Compare
yux0
reviewed
Feb 1, 2023
yux0
approved these changes
Feb 1, 2023
MichaelSnowden
force-pushed
the
snowden/qs-revert
branch
from
77a40c4 to
9659920
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
I reverted the fx changes in 285bf33 to keep the interface compatible.
Why?
Some users rely on this group tag.
How did you test it?
Existing unit tests cover cases when this queue should / should not be provided.
Potential risks
None
Is hotfix candidate?
No