Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove internal-frontend from default services #3849

Merged
merged 1 commit into from
Jan 26, 2023
+12 −3
Merged

Remove internal-frontend from default services #3849

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/server/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ func buildCLI() *cli.App {
&cli.StringSliceFlag{
Name: "service",
Aliases: []string{"svc"},
Value: cli.NewStringSlice(temporal.Services...),
Value: cli.NewStringSlice(temporal.DefaultServices...),
Usage: "service(s) to start",
},
},
Expand Down
13 changes: 11 additions & 2 deletions temporal/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,16 +43,25 @@ type (
}
)

// Services is the list of all valid temporal services as strings (needs to be strings to keep
// ServerOptions interface stable)
var (
// Services is the set of all valid temporal services as strings (needs to be strings to
// keep ServerOptions interface stable)
Services = []string{
string(primitives.FrontendService),
string(primitives.InternalFrontendService),
string(primitives.HistoryService),
string(primitives.MatchingService),
string(primitives.WorkerService),
}

// DefaultServices is the set of services to start by default if services are not given on
// the command line.
DefaultServices = []string{
string(primitives.FrontendService),
string(primitives.HistoryService),
string(primitives.MatchingService),
string(primitives.WorkerService),
}
)

// NewServer returns a new instance of server that serves one or many services.
Expand Down