Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handover callback #3847

Merged
merged 2 commits into from
Jan 26, 2023
Merged

Fix handover callback #3847

merged 2 commits into from
Jan 26, 2023

Conversation

yycptt
Copy link
Member

@yycptt yycptt commented Jan 26, 2023

What changed?

  • Remove ns from shard context handover map if it's no longer in handover state

Why?

How did you test it?

  • Tested in test cluster

Potential risks

Is hotfix candidate?

@yycptt yycptt requested a review from yux0 January 26, 2023 00:40
@yycptt yycptt requested a review from a team as a code owner January 26, 2023 00:40
@yycptt yycptt merged commit 5c23836 into temporalio:master Jan 26, 2023
@yycptt yycptt deleted the fix-handover-callback branch January 26, 2023 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yiminc yiminc yiminc approved these changes

@yux0 yux0 Awaiting requested review from yux0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yycptt @yiminc