Fix visibility processor panic on add after stop #3830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiminc
reviewed
Jan 25, 2023
yycptt
reviewed
Jan 25, 2023
yycptt
reviewed
Jan 26, 2023
yycptt
reviewed
Jan 26, 2023
common/persistence/visibility/store/elasticsearch/processor_test.go
Outdated
Show resolved
Hide resolved
common/persistence/visibility/store/elasticsearch/processor_test.go
Outdated
Show resolved
Hide resolved
alexshtin
approved these changes
Jan 31, 2023
yycptt
approved these changes
Feb 1, 2023
Comment on lines
189
to
191
| errFuture := future.NewFuture[bool]() | ||
| errFuture.Set(false, errVisibilityShutdown) | ||
| return errFuture |
There was a problem hiding this comment.
nit: now we can reuse the future in newFuture and avoid allocating a new channel.
Not related to your PR but it seems like the assignment on L202 will cause the underlying channel in newFuture not getting closed. I am not sure if golang GC can handle this case or result in some leak. cc @alexshtin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Added a RWLock to wait for in-progress
Addcalls and prevent newAddcalls before shutting down.Any add requests after the processor has been stopped are dropped and a warn-level message is logged.
Why?
Bug fix.
How did you test it?
New unit test.
Potential risks
No risks.
Is hotfix candidate?
No.