Start the archival queue iff history or visibility archival is enabled in the static config #3827
Conversation
MichaelSnowden
force-pushed
the
snowden/start-archival-queue-conditionally
branch
from
46876a6 to
2c9c966
Compare
| @@ -52,6 +52,7 @@ type ( | |||
| ReadEnabled() bool | |||
| GetNamespaceDefaultState() enumspb.ArchivalState | |||
| GetNamespaceDefaultURI() string | |||
| StaticClusterState() ArchivalState | |||
There was a problem hiding this comment.
can it use GetClusterState()?
There was a problem hiding this comment.
See below comment
| queueFactorySet.TimerQueueFactory, | ||
| queueFactorySet.VisibilityQueueFactory, | ||
| } | ||
| if archivalMetadata.GetHistoryConfig().StaticClusterState() == archiver.ArchivalEnabled || archivalMetadata.GetVisibilityConfig().StaticClusterState() == archiver.ArchivalEnabled { |
There was a problem hiding this comment.
can it call ClusterConfiguredForArchival?
There was a problem hiding this comment.
No because that can change based on the dynamic config, and so we need to turn it on during startup using the static config because otherwise the dynamic config for durable archival may turn on, and then we'll start producing tasks to a queue which is not running:
There was a problem hiding this comment.
Make sense to me now. I guess this will be simplified after deprecate the archival workflow?
There was a problem hiding this comment.
Unfortunately, not really. The durable archival flag will be removed, but the two-tier archival switch will still exist, and we actually need to keep it that way.
…d in the static config (#3827) Enable archival queue factory iff it is enabled in the static config
…d in the static config (#3827) Enable archival queue factory iff it is enabled in the static config
What changed?
^title
Why?
We don't want to start the archival queue if there's no possibility that archival tasks will even be produced because a lot of users don't even use this feature.
How did you test it?
I added several unit tests to the QueueModule which verify that the archival queue factory is only provided conditionally, but all other queues are always provided.
Potential risks
None
Is hotfix candidate?
No