Read cluster shard count from DB #3788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meiliang86
approved these changes
Jan 10, 2023
| @@ -733,10 +733,16 @@ func loadClusterInformationFromStore(ctx context.Context, config *config.Config, | |||
| return err | |||
| } | |||
| metadata := item.(*persistence.GetClusterMetadataResponse) | |||
| shardCount := metadata.HistoryShardCount | |||
| if shardCount == 0 { | |||
| // This is to add backward compatibility to the config based cluster connection. | |||
There was a problem hiding this comment.
Do I understand correct this only applies to ancient versions of Temporal Server?
There was a problem hiding this comment.
Recent versions should always have this stored in DB?
There was a problem hiding this comment.
Yes. If the clusters are using tctl to connect, then it should have the shard count. If the clusters connection is the legacy config-base, the shard count could be 0. We don't want to support the config base connection so I just assume the clusters shard count must be equal if they are using config base connection.
yycptt
approved these changes
Jan 11, 2023
wxing1292
approved these changes
Jan 12, 2023
yux0
added a commit
that referenced
this pull request
Jan 12, 2023
yux0
added a commit
that referenced
this pull request
Jan 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Read cluster shard count from DB
Why?
Read cluster shard count from DB and use in cluster cache.
How did you test it?
Unit tests
Potential risks
Is hotfix candidate?