Remove task max retry count config #3771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexshtin
approved these changes
Jan 4, 2023
service/history/queues/executable.go
Outdated
| @@ -209,7 +208,7 @@ func (e *executableImpl) HandleErr(err error) (retErr error) { | |||
| defer e.Unlock() | |||
|
|
|||
| e.attempt++ | |||
| if e.attempt > e.criticalRetryAttempt() { | |||
| if e.attempt > taskCriticalAttempts { | |||
There was a problem hiding this comment.
Log message is bad. "Critical" is already in the tag and number of attempts is missing (but might be useful):
e.logger.Error("Error processing task after number of attempts.", tag.Error(err), tag.Attempt(e.attempt), tag.OperationCritical)
There was a problem hiding this comment.
I am not sure how useful # of attempts is in the log given that we have the attempt count metric. But I can add it.
Re. the message itself, I kinda agree. My main concern is oncall needs to memorize a new way for finding this important log (this message is used/searched a lot). So if it's not something you have strong opinion on, I'd like to leave it as is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
How did you test it?
Potential risks
Is hotfix candidate?