Create an FX Module for Archival #3726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelSnowden
force-pushed
the
durable-archival/module
branch
from
81fac5e to
22299b9
Compare
MichaelSnowden
changed the title
yux0
reviewed
Dec 21, 2022
MichaelSnowden
force-pushed
the
durable-archival/module
branch
from
22299b9 to
573511f
Compare
yycptt
reviewed
Dec 21, 2022
service/history/archival/fx.go
Outdated
Comment on lines
39
to
41
| return quotas.NewRateLimiter( | ||
| config.ArchivalBackendMaxRPS(), | ||
| int(math.Ceil(config.ArchivalBackendMaxRPS())), |
There was a problem hiding this comment.
This means changing rps requires a service restart to take effect, maybe use dynamic rate limiter? NewDefaultOutgoingRateLimiter?
There was a problem hiding this comment.
Oh, much better, thanks! Should I mark this old constructor as deprecated in favor of NewDefaultOutgoingRateLimiter?
MichaelSnowden
force-pushed
the
durable-archival/module
branch
from
573511f to
207f2e9
Compare
yux0
approved these changes
Dec 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
I made this change so that we can inject the required dependencies into the archival queue
How did you test it?
I tested this by modifying our tests to use this module instead of the normal constructor, and I then checked test coverage as well. I also ran a simple
make start. Additionally, this dependency isn't required anywhere yet, so it shouldn't actually be run in prod.Potential risks
None.
Is hotfix candidate?
No