Use generics in jitter #3717
Merged
Use generics in jitter #3717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnr
reviewed
Dec 16, 2022
common/backoff/jitter.go
Outdated
| return base + addon | ||
| var base float64 | ||
| var addon float64 | ||
| switch i := any(input).(type) { |
There was a problem hiding this comment.
Do you know if the compiler is smart enough to compile this into separate functions that don't require a runtime type switch?
Ok, I tried it on compiler explorer and it looks like the answer is no: it makes two separate versions and still has a lot of logic around the type switch
Co-authored-by: David Reiss <[email protected]>
Co-authored-by: David Reiss <[email protected]>
yycptt
approved these changes
Jan 13, 2023
| @@ -198,7 +198,7 @@ func (r *TaskGeneratorImpl) GenerateWorkflowCloseTasks( | |||
| } | |||
| // We schedule the archival task for a random time in the near future to avoid sending a surge of tasks | |||
| // to the archival system at the same time | |||
| delay := backoff.JitDuration(r.config.ArchivalProcessorArchiveDelay(), archivalDelayJitterCoefficient) / 2 | |||
| delay := backoff.Jitter(r.config.ArchivalProcessorArchiveDelay(), archivalDelayJitterCoefficient) / 2 | |||
There was a problem hiding this comment.
Intentionally skip this because of test verify the jitter. I will see if I can use the full jitter and have the test pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Use generics in jitter
Why?
Use generics in jitter
How did you test it?
Potential risks
Is hotfix candidate?