Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sanity check for shard id validation #3714

Closed
wants to merge 4 commits into from
Closed

Add sanity check for shard id validation #3714

wants to merge 4 commits into from

Conversation

yux0
Copy link
Contributor

@yux0 yux0 commented Dec 15, 2022

What changed?
Add sanity check for shard id validation

Why?
To avoid create zombie shard entry in the db

How did you test it?

Potential risks

Is hotfix candidate?

@yux0 yux0 requested a review from yycptt December 15, 2022 21:01
@yux0 yux0 marked this pull request as ready for review December 15, 2022 21:01
@yux0 yux0 requested a review from a team as a code owner December 15, 2022 21:01
yycptt
yycptt reviewed Dec 17, 2022
View reviewed changes
Copy link
Member

@yycptt yycptt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if this check should be done in persistence layer or an interceptor for history service.

@yux0
Copy link
Contributor Author

yux0 commented Jan 4, 2023

Move to shard controller. #3776

@yux0 yux0 closed this Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yycptt yycptt yycptt left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yux0 @yycptt