Handle namespace not found in replication #3557
Merged
+17
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meiliang86
reviewed
Nov 4, 2022
| if e.currentCluster == targetCluster { | ||
| shouldProcessTask = true | ||
| break FilterLoop | ||
| switch err.(type) { |
There was a problem hiding this comment.
I feel like an existing unit test should fail? Otherwise we probably don't have proper test coverage :)
I stamped this PR but please use your judgement here.
There was a problem hiding this comment.
To me it looks like embedding the shouldProcessTask logic in the error handling part makes the code a bit hard to understand.
(FYI, currently the only error returned by GetNamespaceByID is namespace not found, but that may change in the future if we make to make the cache read through. so check error type is 👍 )
There was a problem hiding this comment.
Revert to original logic and just handle namespace not found error
meiliang86
approved these changes
Nov 4, 2022
|
Also wait for @yycptt to stamp before merge. |
yycptt
approved these changes
Nov 8, 2022
nagl-temporal
pushed a commit
that referenced
this pull request
Nov 9, 2022
* Handle ns not found in replication
nagl-temporal
pushed a commit
that referenced
this pull request
Nov 9, 2022
* Handle ns not found in replication
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
How did you test it?
Existing tests
Potential risks
Is hotfix candidate?
No