Implement new schedule API features #3337

dnr · 2022-09-08T07:07:22Z

What changed?

New schedule features: single string cron expressions, and compiling that and CalendarSpec into StructuredCalendarSpec
Validate and canonicalize schedule specs on create + update

Why?

How did you test it?
unit tests, integration test

service/frontend/workflow_handler.go

service/worker/scheduler/calendar.go

service/worker/scheduler/calendar_test.go

service/worker/scheduler/spec.go

service/worker/scheduler/calendar.go

yiminc reviewed Sep 8, 2022

View reviewed changes

dnr force-pushed the sched5 branch from 7804d0d to b1ced54 Compare September 10, 2022 23:39

yiminc approved these changes Sep 12, 2022

View reviewed changes

service/worker/scheduler/calendar.go Outdated Show resolved Hide resolved

dnr force-pushed the sched5 branch from b1ced54 to 27f2873 Compare September 12, 2022 21:31

dnr added 11 commits September 12, 2022 17:35

bump api

0792119

schedule library changes

6d28f65

validate

f91850b

update unit tests

20a85a5

canonicalize in addition to validate

13fd873

spec too

e8584b9

tweaks

0131a26

update for cron_string

06e2269

fix timezone name in cron string logic

f7354b2

get rid of 7s in ranges

4a2f299

special case for year ranges

33491df

dnr force-pushed the sched5 branch from 27f2873 to 33491df Compare September 13, 2022 00:35

dnr marked this pull request as ready for review September 13, 2022 00:35

dnr requested a review from a team as a code owner September 13, 2022 00:35

dnr added 3 commits September 12, 2022 17:49

added more comment

c3df074

check TimezoneData too

01dca36

make staticcheck happy

d05d2c3

dnr merged commit cb2cc6f into temporalio:master Sep 13, 2022

dnr deleted the sched5 branch September 13, 2022 03:44

Provide feedback