Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version graph fixes #3287

Closed
wants to merge 5 commits into from
Closed

Version graph fixes #3287

wants to merge 5 commits into from

Conversation

Sushisource
Copy link
Member

What changed?

  • Don't allow removing nodes. It opens up too many confusing questions about what to do with open workflows, and the effect of removing a node can be accomplished by just adding a new version.
  • Fix some straight up bugs

Why?
Bugs bad, obviousness good.

How did you test it?
Many new tests, improved fuzzer

Potential risks
nope

Is hotfix candidate?
no

@Sushisource Sushisource requested a review from a team as a code owner August 31, 2022 20:31
@Sushisource
Copy link
Member Author

Closing in favor of #3432

@Sushisource Sushisource deleted the version-graph-fixes branch September 27, 2022 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Sushisource