Use correct time for initial schedule memo (#4128)

temporalio · Mar 31, 2023 · c97c973 · c97c973
1 parent fec04d1
commit c97c973
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/service/frontend/workflow_handler.go b/service/frontend/workflow_handler.go
@@ -4969,7 +4969,7 @@ func (wh *WorkflowHandler) cleanScheduleMemo(memo *commonpb.Memo) *commonpb.Memo
 
 // This mutates request (but idempotent so safe for retries)
 func (wh *WorkflowHandler) addInitialScheduleMemo(request *workflowservice.CreateScheduleRequest, args *schedspb.StartScheduleArgs) {
-	info := scheduler.GetListInfoFromStartArgs(args)
+	info := scheduler.GetListInfoFromStartArgs(args, time.Now().UTC())
 	infoBytes, err := info.Marshal()
 	if err != nil {
 		wh.logger.Error("encoding initial schedule memo failed", tag.Error(err))

diff --git a/service/worker/scheduler/workflow.go b/service/worker/scheduler/workflow.go
@@ -1012,13 +1012,14 @@ func panicIfErr(err error) {
 	}
 }
 
-func GetListInfoFromStartArgs(args *schedspb.StartScheduleArgs) *schedpb.ScheduleListInfo {
+func GetListInfoFromStartArgs(args *schedspb.StartScheduleArgs, now time.Time) *schedpb.ScheduleListInfo {
 	// note that this does not take into account InitialPatch
 	fakeScheduler := &scheduler{
 		StartScheduleArgs: *args,
 		tweakables:        currentTweakablePolicies,
 	}
 	fakeScheduler.ensureFields()
 	fakeScheduler.compileSpec()
+	fakeScheduler.State.LastProcessedTime = timestamp.TimePtr(now)
 	return fakeScheduler.getListInfo()
 }
diff --git a/tests/schedule_test.go b/tests/schedule_test.go
@@ -695,6 +695,8 @@ func (s *scheduleIntegrationSuite) TestListBeforeRun() {
 		RequestId:  uuid.New(),
 	}
 
+	startTime := time.Now()
+
 	_, err := s.engine.CreateSchedule(NewContext(), req)
 	s.NoError(err)
 
@@ -714,6 +716,7 @@ func (s *scheduleIntegrationSuite) TestListBeforeRun() {
 		s.Equal(wt, entry.Info.WorkflowType.Name)
 		s.False(entry.Info.Paused)
 		s.Greater(len(entry.Info.FutureActionTimes), 1)
+		s.True(entry.Info.FutureActionTimes[0].After(startTime))
 		return true
 	}, 10*time.Second, 1*time.Second)