Skip to content

Commit

Permalink
Fix metrics tagging in stream replication task processing (#4625)
Browse files Browse the repository at this point in the history
<!-- Describe what has changed in this PR -->
**What changed?**
* Fix metrics tagging in stream replication task processing

<!-- Tell your future self why have you made these changes -->
**Why?**
Wrong tag is used

<!-- How have you verified this change? Tested locally? Added a unit
test? Checked in staging env? -->
**How did you test it?**
N/A

<!-- Assuming the worst case, what can be broken when deploying this
change to production? -->
**Potential risks**
N/A

<!-- Is this PR a hotfix candidate or require that a notification be
sent to the broader community? (Yes/No) -->
**Is hotfix candidate?**
Yes
  • Loading branch information
wxing1292 authored and dnr committed Jul 21, 2023
1 parent bcbb3b9 commit a466c4d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion service/history/replication/executable_task.go
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ func (e *ExecutableTaskImpl) Nack(err error) {
}
e.MetricsHandler.Counter(metrics.ReplicationTasksFailed.GetMetricName()).Record(
1,
metrics.OperationTag(metrics.SyncActivityTaskScope),
metrics.OperationTag(e.metricsTag),
metrics.NamespaceTag(namespaceName),
)
}
Expand Down

0 comments on commit a466c4d

Please sign in to comment.