Skip to content

Commit

Permalink
Enable durable archival (#3828)
Browse files Browse the repository at this point in the history
  • Loading branch information
MichaelSnowden committed Jan 31, 2023
1 parent 10c0b6f commit 63bf1e5
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion service/history/configs/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -410,7 +410,7 @@ func NewConfig(dc *dynamicconfig.Collection, numberOfShards int32, isAdvancedVis
NumArchiveSystemWorkflows: dc.GetIntProperty(dynamicconfig.NumArchiveSystemWorkflows, 1000),
ArchiveRequestRPS: dc.GetIntProperty(dynamicconfig.ArchiveRequestRPS, 300), // should be much smaller than frontend RPS
ArchiveSignalTimeout: dc.GetDurationProperty(dynamicconfig.ArchiveSignalTimeout, 300*time.Millisecond),
DurableArchivalEnabled: dc.GetBoolProperty(dynamicconfig.DurableArchivalEnabled, false),
DurableArchivalEnabled: dc.GetBoolProperty(dynamicconfig.DurableArchivalEnabled, true),

BlobSizeLimitError: dc.GetIntPropertyFilteredByNamespace(dynamicconfig.BlobSizeLimitError, 2*1024*1024),
BlobSizeLimitWarn: dc.GetIntPropertyFilteredByNamespace(dynamicconfig.BlobSizeLimitWarn, 512*1024),
Expand Down
1 change: 1 addition & 0 deletions service/history/tests/vars.go
Original file line number Diff line number Diff line change
Expand Up @@ -184,5 +184,6 @@ func NewDynamicConfig() *configs.Config {
config.LongPollExpirationInterval = dc.GetDurationPropertyFilteredByNamespace(dynamicconfig.HistoryLongPollExpirationInterval, 10*time.Second)
config.EnableActivityEagerExecution = dynamicconfig.GetBoolPropertyFnFilteredByNamespace(true)
config.NamespaceCacheRefreshInterval = dynamicconfig.GetDurationPropertyFn(time.Second)
config.DurableArchivalEnabled = dynamicconfig.GetBoolPropertyFn(true)
return config
}

0 comments on commit 63bf1e5

Please sign in to comment.