Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client): Simplify WorkflowClient interceptors #956

Merged
merged 1 commit into from
Nov 9, 2022

Conversation

mjameswh
Copy link
Contributor

@mjameswh mjameswh commented Nov 9, 2022

What changed

  • In WorkflowClientOptions, interceptors should now be provided as an array of interceptor object, rather than an array of factory to those objects under a field named calls.
  • Previous form is still allowed though deprecated

Before:

interceptors: {
    calls: [
        (workflowId) => {
            create(...) => { ... }
        }
    ]
}

Now:

interceptors: [
    {
            create(...) => { ... }
    }
]

Why

Checklist

  • Updated tests
  • Need to update doc and code samples

@mjameswh mjameswh merged commit aa5bba2 into temporalio:main Nov 9, 2022
@mjameswh mjameswh deleted the workflow-client-interceptors branch November 9, 2022 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants