Update Core & pass through new metrics options #1383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add f64 metric types * Add Duration histogram
Sushisource
force-pushed
the
api-key-etc
branch
from
4994e85 to
1e975e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Added new metrics options
Also autoformatted a bunch of stuff. Feel free to exclude that commit.
Why?
Expose Core features
Checklist
Closes [Feature Request] Support metric option for using seconds (and other recent core metric changes) #1380
How was this tested:
Added tests. Unfortunately testing the specifics of the OTel metrics is not really reasonable, but, the option is passed through in the same way as Prom, which is.
Any docs updates needed?