Nexus interceptors #1841
Merged
Nexus interceptors #1841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergundy
commented
Feb 21, 2025
| // | ||
| // All implementations must embed [NexusOperationInboundInterceptorBase] to safely handle future changes. | ||
| // | ||
| // Note: Experimental |
There was a problem hiding this comment.
I marked interceptors as experimental at this stage. Ideally we would have at least one release to let this bake. I don't think this is a blocker for GA.
bergundy
force-pushed
the
nexus-interceptors
branch
from
a9097f3 to
e8ecc32
Compare
Quinn-With-Two-Ns
approved these changes
Feb 21, 2025
bergundy
force-pushed
the
nexus-interceptors
branch
from
10290f6 to
c2dd489
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Added support for Nexus operation inbound and outbound interceptors. The implementation was a bit awkward and required a couple of adapters from and to the Nexus SDK middleware interfaces but that seems reasonable if we want to leverage shared code from that SDK.
Why?
Support tracing and other use cases.
Checklist